search

pgherveou / winston-email

winston-email
email transport logging for winston
8 stars 7 forks source link

Remove 'SMTP' argument from transport creation #3

Open binarymist opened 9 years ago

binarymist commented 9 years ago

Hi.

The first argument ('SMTP' in this case), needs to be removed with the current version of nodemailer. Offending line: https://github.com/pgherveou/winston-email/blob/master/lib/index.js#L32 Line where things are first noticed in nodemailer: https://github.com/andris9/Nodemailer/blob/master/src/nodemailer.js#L84

Thanks muchly!

pgherveou commented 9 years ago

would be great if you could send me a pull request with the changes, we should also lock npm dependencies to latest version

binarymist commented 9 years ago

I'll do that P/R. latest version of winston do you mean?