search

pghilardi / atom-python-virtualenv

Python virtualenv support for Atom
MIT License
16 stars 6 forks source link

custom WORKON_HOME doesn't take effect #25

Closed fzhcary closed 6 years ago

fzhcary commented 7 years ago

In atom, settings_view, manage atom-python-virtualenv UI, after user put a new WORKON_HOME such as $HOME/Envs, it doesn't take effect. I mean

When I look at the code, if customWorkOnHome? customWorkOnHome = customWorkOnHome.replace('$HOME', process.env.HOME) if fs.existsSync customWorkOnHome @getVirtualEnvs([customWorkOnHome], true)

it didn't update the wrapper, customWorkOnHome is parsed, but not used anywhere. maybe you need wrapper = customWorkOnHome at the end

pghilardi commented 7 years ago

@fzhcary ,

You are right. I will fix this soon and I will let you know when a new version is released with this bug fix.

pghilardi commented 6 years ago

@fzhcary ,

Fixed on version 0.15.0. Thanks for the report!