search

pglet / pglet-python

Python client for Pglet - build real-time interactive web apps in Python
MIT License
18 stars 7 forks source link

Updating from setup.py to pyproject.toml #53

Closed MrHemlock closed 2 years ago

MrHemlock commented 2 years ago

This PR serves to to update from the traditional setup.py model to the more modern pyproject.toml. This makes PDM a requirement when building and publishing the project. The proper integrations have been (at least from what we can see) adjusted in AppVeyor and should be ready to go. Should for sure be tested before pushing it through.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

FeodorFitsner commented 2 years ago

Thanks for your PR! Would it make sense to update the requirement for Python to >=3.8? I'm not sure why I put 3.7 in the first place, but even PDM suggests 3.8 by default. Is there any benefit of supporting 3.7?

MrHemlock commented 2 years ago

>=3.7 actually works perfectly. We're going to be using the annotations module from __future__ which will allow us to integrate modern type hinting as far back as 3.7. At present, there isn't anything breaking that would prevent us from using 3.7, so no change needed.