search

pglira / simpleICP

Implementations of a rather simple version of the Iterative Closest Point algorithm in various languages.
MIT License
299 stars 60 forks source link

(C++) 1-based index #24

Open mitjap opened 2 years ago

mitjap commented 2 years ago

I've noticed that in some places you used 1-based indices. I guess all of this should be 0-based?

https://github.com/pglira/simpleICP/blob/1478851961c01eab677bd325f93dff9b85d7a069/c%2B%2B/src/simpleicp.cpp#L164 https://github.com/pglira/simpleICP/blob/1478851961c01eab677bd325f93dff9b85d7a069/c%2B%2B/src/simpleicp.cpp#L181 https://github.com/pglira/simpleICP/blob/1478851961c01eab677bd325f93dff9b85d7a069/c%2B%2B/src/pointcloud.cpp#L82