"Generate Password" creates wrong password length

[Jocky92]

🐛 Bug Report

The generation of the passwords does not work properly. It makes little sense that the maximum length of the syllable may be shorter than the minimum length. The problem could be solved if the maximum length is checked to be longer than the minimum length. Alternatively, the other value could be adjusted automatically when a change is made.

I don't know the process of password generation, but it doesn't make much sense that way. The same problem appears with other number constellations if the distance is always only 1.

🔬 How To Reproduce

click generate Password and chose this settings: Number of Syllables: 5 Minimum Syllable Length: 4 Maximum Syllable Length: 3

Environment

Where are you running/using Password Pusher?

• [x] pwpush.com
• [x] Docker
  • [ ] pwpush-ephemeral
  • [ ] pwpush-mysql
  • [x] pwpush-postgres
  • [ ] custom image
• [ ] Heroku
• [ ] Digital Ocean
• [ ] Microsoft Azure
• [ ] Google Cloud
• [ ] AWS
• [ ] Source Code
• [ ] Other (please specify)

If applicable, what version of Password Pusher? latest Version

Screenshots

[github-actions[bot]]

Hello @Jocky92, thanks for contributing to the Password Pusher community! We will respond as soon as possible.

[pglombardo]

Hi @Jocky92 thanks for pointing this out. The generator definitely needs some improvements. I'll fix this on the next update to the generator code.