search

pglombardo / PasswordPusher

🔐 Securely share sensitive information with automatic expiration & deletion after a set number of views or duration. Track who, what and when with full audit logs.
https://pwpush.com
Apache License 2.0
1.79k stars 329 forks source link

url push with 1-click retrieval step consume two views #2225

Open AkaGabriel32 opened 1 month ago

AkaGabriel32 commented 1 month ago

🔬 How To Reproduce

Steps to reproduce the behavior:

  1. create a url push
  2. Check "Use a 1-click retrieval step"
  3. Configure a single view
  4. Click "push it"
  5. Try to view for the first time the URL

Environment

📈 Expected behavior

Secret url displayed

📎 Additional context

A message indicates that the secret has expired.

In pwpush.com the audit screen shows one view ok and a second view expired at the same time.

github-actions[bot] commented 1 month ago

Hello @AkaGabriel32, thanks for contributing to the Password Pusher community! We will respond as soon as possible.

pglombardo commented 4 weeks ago

Hi @AkaGabriel32 - I just tested this on my android phone with firefox and couldn't reproduce it. Does it happen for you with another browser or device?

AkaGabriel32 commented 4 weeks ago

Hi @pglombardo ;) I have just tested with a second phone (android, xiaomi redmi note 10, firefox): problem reproduced. I have just tested with an Ubuntu LTS 24.04 PC, Firefox: problem reproduced. audit config error firefox

The problem only occurs if we choose "Use a 1-click retrieval step". In this case each view is counted twice (for my tests).

pglombardo commented 3 weeks ago

Hi @AkaGabriel32 - thanks for the helpful info. I don't doubt this is happening for you. I do think that something is double fetching. Maybe like a link preloader... not sure. Or maybe something else...

I'll try again to reproduce this soon.