pglombardo / PasswordPusher

🔐 Securely share sensitive information with automatic expiration & deletion after a set number of views or duration. Track who, what and when with full audit logs.
https://pwpush.com
Apache License 2.0
1.79k stars 329 forks source link

Adjust helm chart to runAsNonRoot #2252

Closed domi2120 closed 3 weeks ago

domi2120 commented 3 weeks ago

Description

Currently the helm chart does not set a podSecurityContext. This may prevent the use in kubernetes clusters which do not allow images that run as root for security reasons.

The Container already uses a non root user, so setting runAsNonRoot and specifying the User/Group ID (because runAsNonRoot requires a numeric user for validation) is sufficient. This allows the use in kubernetes clusters which do not allow images running as root.

Type of Change

Checklist

pglombardo commented 3 weeks ago

Hi @domi2120 - thanks for the contribution/it makes sense.

cc: @mindovermiles262, @aduss-storable & @MindTooth who added & tested our initial helm chart support. I'll merge this soon unless I hear otherwise.

We need to merge #1589 too.

pglombardo commented 3 weeks ago

Thanks @domi2120 @MindTooth !