pglombardo / PasswordPusher

🔐 Securely share sensitive information with automatic expiration & deletion after a set number of views or duration. Track who, what and when with full audit logs.
https://docs.pwpush.com
Apache License 2.0
1.98k stars 343 forks source link

Untauthenticated SMTP fails "No SMTP username provided" #2471

Open kaffe19 opened 2 weeks ago

kaffe19 commented 2 weeks ago

🐛 Bug Report

🔬 How To Reproduce

Steps to reproduce the behavior:

  1. pull pglombardo/pwpush:latest

  2. set PWPMAILSMTP_ENABLE_STARTTLS_AUTO -> false

  3. do not set PWPMAILSMTP_AUTHENTICATION, PWPMAILSMTP_USER_NAME or PWPMAILSMTP_PASSWORD (exactly as when it was working before)

  4. send test mail from console: password-pusher(prod)> TestMailer.send_test_email("abc@cde.ef").deliver_now

--> Configured FROM: address: 'abc@abc.abc' app/mailers/test_mailer.rb:7:in `send_test_email': No SMTP username provided: smtp_user_name (StandardError)

SMTPsettings:

password-pusher(prod)> Rails.application.config.action_mailer.smtp_settings => {:address=>"mysmtpserver.example.com", :port=>25, :open_timeout=>10, :read_timeout=>10, :enable_starttls_auto=>false}

Where are you running/using Password Pusher?

📈 Expected behavior

Mail should be deliverd to SMTP server unauthenticaded on port 25, in case user is not set.

github-actions[bot] commented 2 weeks ago

Hello @kaffe19, thanks for contributing to the Password Pusher community! We will respond as soon as possible.