pglombardo / PasswordPusher

🔐 Securely share sensitive information with automatic expiration & deletion after a set number of views or duration. Track who, what and when with full audit logs.
https://docs.pwpush.com
Apache License 2.0
2.08k stars 358 forks source link

Auditing Active Passwords/Files/URLS to expire them shows expiry page and not the dashboard after expiring a push. #2647

Open wedowhateverwewant opened 2 weeks ago

wedowhateverwewant commented 2 weeks ago

Checklist

❓ Question

This is true for Password, Files, and URL pushes.

When going to the dashboard and going in the audit section for a push to expire it manually , instead of bringing you back to the dashboard it displays this link is expired ( see image) page right after you expire a push. im on the latest version 1.46.3 , using docker compose pwpush/mysql + gateway image

pglombardo commented 2 weeks ago

Hi @wedowhateverwewant - this is be design with a recent change. It was done in an effort to simplify the code in tandem with the public gateway. For example, if you are accessing a push delivery page from the gateway, there is not audit log to redirect to because in the gateway, the audit log isn't enabled - so I just simplified everything.

Steps like this have to be taken to simplify the code base which results in less bugs and easier maintenance for me with my limited time.

End users never need to be taken back to the audit log and push creators can manually enter the base url to access their dashboard if needed.

I hope I explained this well enough.