pgmanutd / node-talisman

👌 By hooking into the pre-push hook provided by Git, Talisman validates the outgoing changeset for things that look suspicious - such as authorization tokens and private keys.
https://www.npmjs.com/package/node-talisman
MIT License
10 stars 0 forks source link

Hello from husky-talisman! #8

Open olmesm opened 2 years ago

olmesm commented 2 years ago

Hi Prashant!

I'd love to remove the user split between node-talisman and husky-talisman, but there are a few things that would prevent full adoption of your package from my side or the few of my package's users.

I originally created husky-talisman to fulfil a need for zero-dependency due to client requirements. This is the only challenge I would raise to what you have created - they do have a lot of similarities after all.

Would you have any interest in targeting zero-dependencies for this? Do you have capacity?

pgmanutd commented 2 years ago

Hey Oliver,

Long time back I created this package when I was in Thoughtworks. I needed cli support in one of my node projects but didn't find any package online. This package just downloads the latest talisman cli and users can run it as they like. Sure I can make it independent of any package. Right now it uses the following:

I'll try to see if I can pull this one over the weekend or probably next week 😃

Also I need to do some cleanup and replace few deprecated or outdated things with the latest one's but that can be done later also