search

pgmichael / wavenet-for-chrome

Chrome extension that transforms highlighted text into high-quality natural sounding audio using Google Cloud's Text-to-Speech.
http://wavenet-for-chrome.com
MIT License
132 stars 52 forks source link

Removes 5000 character limit by splitting text into sentences. #38

Closed pgmichael closed 3 years ago

pgmichael commented 3 years ago

This should remove the 5000 character limit by splitting the text into sentences.

For audio playback, the second sentence is always fetched preemptively to avoid any stuttering.

pgmichael commented 3 years ago

Thanks for testing this @simsim314, the shortcut issue is actually caused by loading multiple extension that share the same shortcuts (we could handle this more gracefully though).

superluig164 commented 3 years ago

I can directly see the shortcut issue myself, and I'm using the Web Store version. I removed the shortcut to download an MP3, and so it shows up blank.

simsim314 commented 3 years ago

I guess the shortcut issue if happens only in second addon, is not a big deal as most people aren't using the same addon twice - and if they are, no one cares that one of the menus is empty. More wanted to leave my report on what I see, to make sure it's not a real issue of text not showing in the new one or something more critical.