search

pgmodeler / plugins

pgModeler plug-ins repository
21 stars 6 forks source link

Assisting the user when running qmake with the plugins in. #6

Closed Maxzor closed 4 years ago

Maxzor commented 4 years ago

What do you think of interacting with the user? It is not kconfig "make menuconfig" yet but well :)

Maxzor commented 4 years ago

I have almost finished a join solver rewrite, will pr within a few hours. Using preprocessor macros and this commit, people could choose to build the query builder without the automatic path module. Bit long to explain trying it is best!

rkhaotix commented 4 years ago

Hmm... I don't know if I agree with this approach because for automated building processes (like linuxdeploy.sh) the script will be paused waiting for the user's interaction. Things can be worse if the building process is being run in a only CI/Build server where the user has no interaction with the shell.

Honestly, just warn the user about the absence of deps is enough. Oh, and a well written README file is also a good idea (yours seems good enough). :)

Maxzor commented 4 years ago

I agree this should not disturb packagers, build farms, and the likes.

Automation folks can flag in their qmake command CONFIG+=NON_INTERACTIVE_QMAKE and it is exactly like before. You can of course keep NON_INTERACTIVE the default with that flag in pgmodeler.pri, and update pgmodeler.io support doc to remove the flag for a manual installation with CONFIG-=this_flag.

I think such an interaction can help people feel they are a bit more not alone... P.S. Could also improve the wording with positive rather than double negative CONFIG+=INTERACTIVE should do it.

Maxzor commented 4 years ago

Will PR with the feature the other way later.