pgmoneta / pgmoneta

Backup / restore solution for PostgreSQL
https://pgmoneta.github.io
BSD 3-Clause "New" or "Revised" License
121 stars 38 forks source link

Password Generation Function Generates Strings Containing Configuration File Comment Characters #262

Closed joanjeremiah closed 1 month ago

joanjeremiah commented 1 month ago

I noticed the generate_password function in the admin.c file is currently generating passwords that may contain characters '#' and ';'. These characters pose a problem when used in passwords intended for configuration files, as they could inadvertently trigger comment recognition ( as an inline comment ) within the configuration syntax.

Possible solutions include excluding '#' and ';' characters from the list of characters used in password generation. @jesperpedersen Can I implement this solution?

jesperpedersen commented 1 month ago

Yes