ankurankan
commented
6 years ago @chaonan99 Thanks a lot for the PR.
Closed chaonan99 closed 6 years ago
ankurankan
commented
6 years ago @chaonan99 Thanks a lot for the PR.
Seems that we cannot import everything we need directly from
pgmpy.factors, symbols are separated into sub modules (but I feel it a little messy). To be concrete,from pgmpy.factors import JointGaussianDistribution as JGD->from pgmpy.factors.distributions import GaussianDistribution as JGDfrom pgmpy.factors import CanonicalFactor->from pgmpy.factors.continuous import CanonicalDistributionfrom pgmpy.factors import LinearGaussianCPD->from pgmpy.factors.continuous import LinearGaussianCPD(There is also a bug in the implementation of
LinearGaussianBayesianNetwork.add_cpdsso the notebook contains a little hack to deal with that which should be removed after the bug fixed.)