search

pgmpy / pgmpy_notebook

Short Tutorial to Probabilistic Graphical Models(PGM) and pgmpy
http://pgmpy.org/
MIT License
371 stars 212 forks source link

Use X_train instead of data to calculate the joint probabilitites #46

Closed pthomaid closed 4 years ago

pthomaid commented 4 years ago

Example joint probability used all of the data instead of using only the training data. The error was obvious if one summed the joint probabilities before which was 1.25 (instead of 1).

ankurankan commented 4 years ago

@pthomaid Thanks for the PR and pointing out the mistake.