search

pgmpy / pgmpy_notebook

Short Tutorial to Probabilistic Graphical Models(PGM) and pgmpy
http://pgmpy.org/
MIT License
368 stars 213 forks source link

Notebook for BN Parameter & Structure Learning #7

Closed chrisittner closed 7 years ago

chrisittner commented 7 years ago

Happy about comments.

Where should I include it in the numbering of the notebooks?

ankurankan commented 7 years ago

@chrisittner I will number it before merging. Few suggestions:

  1. I feel like making the notebooks a bit more structured would be nice. For example in MaximumLikelihood Estimator you have mentioned about 2 drawbacks of this method. If you put it under a sub heading and in points, I think it would be much easier for people to find it quickly.
  2. I would like to see a bit more detail on theoretical parts. Our aim with the notebooks is to have a tutorial for PGM using pgmpy.
  3. You can highlight code in markdown. You have used some_method()-method at a lot of places. I would suggest you to replace it with some_method.
  4. The section on Independence tests seems out of place. I don't feel like it should be in Structure learning.
ankurankan commented 7 years ago

@chrisittner Merging this for now but needs to be fixed.