search

pgmpy / pgmpy_viz

A web based GUI for pgmpy
MIT License
13 stars 20 forks source link

Discussion on comments and style problems #15

Closed ankurankan closed 10 years ago

ankurankan commented 10 years ago

We should not have obvious inline comments.

templates/index.html:

Line 174: Extra space after node_id_str Line 177: I don't think we need this comment Line 189: I don't think we need this comment Line 192: ----------------Same------------------------- Line 204, 205, 206: Debugging code Line 209: Extra space after target_node_id Line 217: Why do we need the comment After creating the edges, set these to null? Everyone can see that you are setting it to null. If you would have written why you are doing that it would be much more meaningful. Line 226: Debugging code Line 228: I don't know if $(document).keydown(function(e) is a function definition. If it is, writing comment as you have written in Line 160 would look much better. Opinion?

pramttl commented 10 years ago

Please add the comments inline with the code. Its hard to comprehend them here. Further any change on my local branch gets me out of sync with the lines you have mentioned.

ankurankan commented 10 years ago

@pramttl: No problem, I have made the changes.