Closed neilsimp1 closed 5 years ago
Wow thanks! I'll review this in a day or so, but a quick skim suggests it should be good to go.
Like I mentioned above, I'd like to build some sort of framework with a templating system for gopher, and it would fit in as a Provider to GopherServer. Would you be interested in me contributing that? Would that belong in my own repo?
Missed this in my reply. That sounds like a great idea and I'd be happy to contribute. I've been meaning to do some work on this sounds like a good way to get back in.
Happy for it to be included in this repo as long as it works for you.
I should mention too, I have only tested this on Linux, not Windows. It should work there but if there are any issues with Windows I'd be happy to look into it.
Hi @pgodwin,
I had an inspiration last week to create something like a ASP.NET MVC-like framefork, but for gopher. I started writing my own gopher server in C#, but realized after a quick search that you already had a pretty good looking one here. I saw at https://github.com/pgodwin/GopherServer/issues/2 that you wanted this to run on .NET Core. I have a PR for you here with just that.
What I changed
using
statements=>
functionsWhat I tested
Are you interested in taking this PR? Like I mentioned above, I'd like to build some sort of framework with a templating system for gopher, and it would fit in as a Provider to GopherServer. Would you be interested in me contributing that? Would that belong in my own repo?
Let me know your thoughts!