search

pgpgeek / thunderbird-addon-eml-editor

MIT License
5 stars 2 forks source link

Attachment not allowing to save eml.. #7

Open xlovinglyx opened 2 years ago

xlovinglyx commented 2 years ago

Sad new issue, it's not possible to use the save button for composed emails anymore "with attachment" .. . there's a bug somewhere.

jorgk3 commented 2 years ago

getFile() is deprecated. You need to change it like here: https://github.com/darktrojan/shrunked/commit/84c032b7fda86d3e5ec109b17cc884cf6c96ad09

I edited the add-on and uploaded a new version to http://www.jorgk.com/misc/addons102/.

All I've changed was in scripts/others/save_eml.js:

async function getFileAttachmentData(file) {
  let nfile = await browser.compose.getAttachmentFile(file.id);
AleKnight7 commented 2 months ago

getFile() is deprecated. You need to change it like here: darktrojan/shrunked@84c032b

I edited the add-on and uploaded a new version to http://www.jorgk.com/misc/addons102/.

All I've changed was in scripts/others/save_eml.js:

async function getFileAttachmentData(file) {
  let nfile = await browser.compose.getAttachmentFile(file.id);

Your fix was working up to version 115.- In 128.2.0 it stopped working

Betterbird commented 2 months ago

Here's a version fixed for Thunderbird/Betterbird 128: https://www.betterbird.eu/downloads/Addons-fixed-for-BB/eml_editor-1.10-tb.xpi

UPDATE: In the future, e-mail the Betterbird Project directly, I didn't see the e-mail notification.