pgpointcloud / pointcloud

A PostgreSQL extension for storing point cloud (LIDAR) data.
https://pgpointcloud.github.io/pointcloud/
Other
397 stars 108 forks source link

PG16: error: too few arguments to function ‘stringToQualifiedNameList’ #338

Closed df7cb closed 1 year ago

df7cb commented 1 year ago

pgpointcloud fails to build with PG16:

15:01:32 pc_pgsql.c: In function ‘pointcloud_get_full_version_schema’:
15:01:32 pc_pgsql.c:47:17: error: too few arguments to function ‘stringToQualifiedNameList’
15:01:32    47 |   List *names = stringToQualifiedNameList(proname);
15:01:32       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
15:01:32 In file included from pc_pgsql.c:32:
15:01:32 /usr/include/postgresql/16/server/utils/regproc.h:28:14: note: declared here
15:01:32    28 | extern List *stringToQualifiedNameList(const char *string, Node *escontext);
15:01:32       |              ^~~~~~~~~~~~~~~~~~~~~~~~~

https://pgdgbuild.dus.dg-i.net/view/Binaries-Beta/job/pgpointcloud-binaries-beta/lastFailedBuild/architecture=amd64,distribution=sid/console

A fix would be appreciated so we can update the Debian packages for PG16.

robe2 commented 1 year ago

I'll try to provide a patch for this later today.

df7cb commented 1 year ago

Could we have a new release with this fix?