search

pgpool / pgpool2

This is the official mirror of git://git.postgresql.org/git/pgpool2.git. Note that this is just a *mirror* - we don't work with pull requests on github. Please subscribe to pgpool-hackers mailing list from our website and submit your patch to this mailing list.
https://www.pgpool.net
Other
305 stars 87 forks source link

Similar branches #52

Closed lexborisov closed 1 month ago

lexborisov commented 1 month ago

Hello, everyone!

Same comparison in branching. Please, see line 773 and 780 of src/parser/outfuncs.c file.

if (node->jointype == JOIN_INNER) 
/* and */
else if (node->jointype == JOIN_INNER)
    if (node->jointype == JOIN_INNER) 
    {
        if (node->usingClause == NIL && node->quals == NULL && !node->isNatural)
            appendStringInfoString(str, " CROSS JOIN ");
        else
            appendStringInfoString(str, " JOIN ");
    }
    else if (node->jointype == JOIN_INNER)
        appendStringInfoString(str, " JOIN ");

Which is correct?

pengbo0328 commented 1 month ago

@lexborisov Thank you for pointing out this issue.

line 780 should be deleted.

I have fixed this issue d34d808bbebb132f1f9e7595c72ee253eef5462f

lexborisov commented 1 month ago

Thanks!