search

pgregory / wetracker

A collaborative web based music creation tool based on the Tracker heritage.
http://pgregory.github.io/wetracker/
MIT License
83 stars 3 forks source link

Zero volume effect causes an exception. #49

Closed pgregory closed 7 years ago

pgregory commented 7 years ago

Description

When an event has zero in the volume effect channel, the notification message causes an exception. Zero should be ignored according the .xm formal documentation anyway. http://modland.com/pub/documents/format_documentation/FastTracker%202%20v2.04%20(.xm).html

Sample song showing the issue: http://modland.com/pub/modules/Fasttracker%202/-%20unknown/back%20to%20basic.xm

Steps to reproduce

  1. Load the song linked above.
  2. Open the developer tools console.
  3. Play the song.
  4. At sequence number 3, pattern 7, about 2/3 way down, WeTracker starts excepting.

Versions