pgregory / wetracker

A collaborative web based music creation tool based on the Tracker heritage.
http://pgregory.github.io/wetracker/
MIT License
83 stars 3 forks source link

Capture and deal with loading errors #82

Closed pgregory closed 7 years ago

pgregory commented 7 years ago

Description

If the loading of a song from the network fails, i.e. returns something other than a 200 code, the system still attempts to process the song, ultimately resulting in an exception that is hidden from the user. It should check the return code and give a meaningful response, dealing with the failure gracefully.

http://wetracker-159510.appspot-preview.com/#/loadsong?play=1&url=http%3A%2F%2Fmodland.com%2Fpub%2Fmodules%2FFasttracker%25202%2FCell%2Fpositive.influences-wrong.xm

Steps to reproduce

  1. Use the link above to try to load a song, the song filename has been intentionally modified to produce an error, it should 404.

Versions