pgriess / node-websocket-client

A Web Socket client for NodeJS
BSD 3-Clause "New" or "Revised" License
150 stars 68 forks source link

Fix the lib for v0.5 and v0.6 of nodejs. It's also backward compatible with v0.4 #19

Open alaingilbert opened 13 years ago

alaingilbert commented 13 years ago

Fix the lib for v0.5 and v0.6 of nodejs. It's also backward compatible with v0.4

quangv commented 13 years ago

hey alain,

thanks for the fix. I merged it with mine, and added try/catches,

would your fix still work if it's done that way?

checkout https://github.com/pgriess/node-websocket-client/pull/21/files

Thanks.

alaingilbert commented 13 years ago

No. Because in node v0.4.x http.request exists, but you need to do http.createClientto make it work. (tested with node v0.4.12 and v0.6.1)