search

pgrimaud / lametric-cryptocurrencies

The ultimate cryptocurrencies app for LaMetric : More than 5000 currencies available!
https://apps.lametric.com/apps/cryptocurrencies/5497
MIT License
37 stars 17 forks source link

Cents should always show hundredth place #14

Closed codysherman closed 3 years ago

codysherman commented 3 years ago

Prices that end in a multiple of 10 cents should show the ending 0.

Example: "123.4" should display as "123.40"

pgrimaud commented 3 years ago

How prices are in a multiple of 10 cents show the ending 0. Only for the price between $100 et $999, to avoid the price being too long on screen size.

codysherman commented 3 years ago

Not sure I described by issue correctly. I understand removing the cents for larger numbers, but when cents are shown, it should always be 2 digits: ❌1.2 ✅1.20

pgrimaud commented 3 years ago

What if crypto worth 0.001$?

i.e. : https://coinmarketcap.com/currencies/bittorrent/

codysherman commented 3 years ago

I'm not saying to crop, $0.001 is fine. I was just saying $4.1 looks really weird. It's definitely an edge case to code for. I understand if it isn't worth fixing.

pgrimaud commented 3 years ago

Alright, gotcha! It's fixed.

Tell me if you got a weird rounding price in the next days.

codysherman commented 3 years ago

Thanks! Will keep an eye on it!