pgrimaud / lametric-cryptocurrencies

The ultimate cryptocurrencies app for LaMetric : More than 5000 currencies available!
https://apps.lametric.com/apps/cryptocurrencies/5497
MIT License
37 stars 17 forks source link

Rate Limiter #37

Closed YanDevDe closed 2 years ago

YanDevDe commented 2 years ago

Hello! Great app, as always! :)

I'm currently facing the issue that I'm always getting the error "Rate Limiter Reached, please wait a bit".

Just letting ya know! :)

Thanks,

Yan

pgrimaud commented 2 years ago

Hello,

Damn, for which displayed currency? USD, EUR, etc.

YanDevDe commented 2 years ago

I'm using EUR! First cryptocurrency which it should appear is BTC and I'm getting this error.

YanDevDe commented 2 years ago

I have 4 cryptocurrency code, FYI!

pgrimaud commented 2 years ago

Damn, I just updated the app. Hope it will fixed it. We have to wait a couple of minutes to get back to normal.

YanDevDe commented 2 years ago

Gotcha, will let you know in one hour! Thank you so much for the quick reply and fix lol!

YanDevDe commented 2 years ago

Looks like it worked! :) Fantastic - Thank you @pgrimaud!

pgrimaud commented 2 years ago

Hope it will work for a long times 😥

YanDevDe commented 2 years ago

Rate Limiter has appeared again. 🥲 - Where does Rate Limiter happens? Is the MarketCap API being called per User or per LaMetric's "Server"?

pgrimaud commented 2 years ago

It's for every users

YanDevDe commented 2 years ago

May want to checkout at coingecko.com - they have much friendlier API & Rate Limiter! Just an idea 😄

pgrimaud commented 2 years ago

Good idea, I will add an option into the app to select data provider (CoinMarketCap or CoinGecko).

It will decrease API calls to CMC and balance into the two data providers.

What do you think about it?

YanDevDe commented 2 years ago

Actually that's an interesting idea! I'm not quite sure how much work it would be - but selecting data providers individually by cryptocurrency could be interesting too?

I only know that I didn't had issue by using CoinGecko for our own software. It's also being called per users. But with CoinMarketCap they were way more stricter so I just gave up on them lol.

pgrimaud commented 2 years ago

IMHO, data providers will be select for all currencies selected on the app.

pgrimaud commented 2 years ago

We switched to Coingecko, so no more rate limit 🎉