search

pgspider / jdbc_fdw

JDBC Foreign Data Wrapper for PostgreSQL
Other
69 stars 23 forks source link

Refactor README.md #14

Closed mkgrgis closed 1 year ago

mkgrgis commented 1 year ago

By https://github.com/ibarwick/firebird_fdw/blob/master/README.md example of advanced FDW documentation

weiting1lee commented 1 year ago

@mkgrgis thanks for the pull request. I have reviewed and found some spelling misses, could you please help me fix it?

mkgrgis commented 1 year ago

@mkgrgis thanks for the pull request. I have reviewed and found some spelling misses, could you please help me fix it?

Yes, @weiting1lee. What about resolving conflict with https://github.com/pgspider/jdbc_fdw/commit/e69cfa37768fcf619891f323afdac6b93fbb9d01#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 ? Who will do it? I can add this information to README.md

weiting1lee commented 1 year ago

@mkgrgis Thank you.

Who will do it? I can add this information to README.md

Appreciate if you can, otherwise we'll do it.

mkgrgis commented 1 year ago

Added in https://github.com/pgspider/jdbc_fdw/pull/14/commits/e6fa9a058bb97f906d02f374acb012fdadc78480 , @weiting1lee , please check.

weiting1lee commented 1 year ago

@mkgrgis Appreciate for this pull request. Reviewed and merged.