Closed mkgrgis closed 1 year ago
Thanks, @nxhai98 -san! I have fixed some problems in https://github.com/mkgrgis/sqlite_fdw/commit/74bcfeaf61fd0b5db579995e4a7fcd7cb8263a08
I add some more comments. Could you please help me check it again?
Yes. Thanks, @nxhai98 !
@mkgrgis
@nxhai98's confirmation has completed. We can accept the PR. Can I merge it?
@t-kataym , yes, you can squash and merge my PR. Reviews by @nxhai98 was very good and helpful for me! My next little PR will be about database encoding, also without breaking of any tests.
@mkgrgis , Thank you for your reply and development. I will merge it.
No SQL behaviour changes.
Preparing to implement SQL behaviour from table discussed in https://github.com/pgspider/sqlite_fdw/issues/66#issuecomment-1504830541
This PR include:
sqlite_convert_to_pg
fromDatum
toNullableDatum
for future properuuid
processing and other special cases such as voidtext
affinity in data forint
column;sqlite3_column_bytes
andsqlite3_column_bytes
for the same data value;