pgspider / sqlite_fdw

SQLite Foreign Data Wrapper for PostgreSQL
Other
219 stars 37 forks source link

Prepare C-language infrastructure for ISO:SQL #74

Closed mkgrgis closed 1 year ago

mkgrgis commented 1 year ago

No SQL behaviour changes.

Preparing to implement SQL behaviour from table discussed in https://github.com/pgspider/sqlite_fdw/issues/66#issuecomment-1504830541

This PR include:

mkgrgis commented 1 year ago

Thanks, @nxhai98 -san! I have fixed some problems in https://github.com/mkgrgis/sqlite_fdw/commit/74bcfeaf61fd0b5db579995e4a7fcd7cb8263a08

mkgrgis commented 1 year ago

I add some more comments. Could you please help me check it again?

Yes. Thanks, @nxhai98 !

t-kataym commented 1 year ago

@mkgrgis
@nxhai98's confirmation has completed. We can accept the PR. Can I merge it?

mkgrgis commented 1 year ago

@t-kataym , yes, you can squash and merge my PR. Reviews by @nxhai98 was very good and helpful for me! My next little PR will be about database encoding, also without breaking of any tests.

t-kataym commented 1 year ago

@mkgrgis , Thank you for your reply and development. I will merge it.