search

pgspider / sqlite_fdw

SQLite Foreign Data Wrapper for PostgreSQL
Other
218 stars 37 forks source link

Add RPM specifiacation #80

Open mkgrgis opened 1 year ago

mkgrgis commented 1 year ago

Create rpm.spec. In continue of https://github.com/pgspider/sqlite_fdw/pull/39

Based on

Thanks to @scj643 and @devrimgunduz

t-kataym commented 1 year ago

@mkgrgis , Thank you for creating the PR.
Is it no problem to start the review?

@MinhLA1410 , Please review it if it is ready.

mkgrgis commented 1 year ago

@mkgrgis , Thank you for creating the PR. Is it no problem to start the review?

Yes, no problems. I'll study about RPM directive words if there will detected any problems.

MinhLA1410 commented 1 year ago

Hi @mkgrgis I tried to build rpm file from your spec. But it does not work. Could you please check again

error: parse error in expression
error: ${HOME}/sqlite_fdw/rpm.spec:25: bad %if condition
mkgrgis commented 1 year ago

Thanks, @MinhLA1410 ! I'll try to get rpm environment, reproduce this problem and check again.

devrimgunduz commented 1 year ago

Why are you trying to add spec file to sqlite_fdw repo? I'm already maintaining it in upstream repo. Also this spec file depends lots of things in the PostgreSQL RPM repo, it is not a standalone one.

mkgrgis commented 1 year ago

Hello, @devrimgunduz ! Thanks for reply and for rpms :-) . I try to add spec file because i want to get rpm files for my colleagues with some new features or with my experiments for user testing. Your rpm files with sqlite_fdw likes me because there is good implementation of lifecycle processes.