pgspider / sqlite_fdw

SQLite Foreign Data Wrapper for PostgreSQL
Other
218 stars 37 forks source link

Refactor data conversion errors and diagnostics, tests, headers and test data directory #91

Closed mkgrgis closed 7 months ago

mkgrgis commented 10 months ago

In this PR:

mkgrgis commented 9 months ago

@t-kataym, this simple PR is ready for review.

mkgrgis commented 8 months ago

@t-kataym , could you please write approximate week of review of this PR? Have pgspider team any plans of a new sqlite_fdw release?

mkgrgis commented 8 months ago

I have some comments for your PR, could you please check it?

All your comments have checked, please start 2nd round of review, @nxhai98 !

mkgrgis commented 8 months ago

All comments are checked and fixed, @nxhai98. Thanks for review! What will be later? 3rd round of your review or review by @t-kataym ?

mkgrgis commented 8 months ago

Ping, @nxhai98 ! Are there any results of 2 rounds of your review? What will be later?

mkgrgis commented 8 months ago

@t-kataym , could you please write approximate week of review and status of this PR? Will there 3rd review round?

mkgrgis commented 8 months ago

Hello @t-kataym and @nxhai98 ! Any chances to have feedback or 3rd review round for this PR? What is the status of this PR? Completely PR description after checking all your comments was updated https://github.com/pgspider/sqlite_fdw/pull/91#issue-1994632771

t-kataym commented 7 months ago

@mkgrgis , Thank you for your contribution.
@nxhai98 , Thank you for your confirmation.
I will merge the PR.