Closed mkgrgis closed 7 months ago
@t-kataym, this simple PR is ready for review.
@t-kataym , could you please write approximate week of review of this PR? Have pgspider team any plans of a new sqlite_fdw
release?
I have some comments for your PR, could you please check it?
All your comments have checked, please start 2nd round of review, @nxhai98 !
All comments are checked and fixed, @nxhai98. Thanks for review! What will be later? 3rd round of your review or review by @t-kataym ?
Ping, @nxhai98 ! Are there any results of 2 rounds of your review? What will be later?
@t-kataym , could you please write approximate week of review and status of this PR? Will there 3rd review round?
Hello @t-kataym and @nxhai98 ! Any chances to have feedback or 3rd review round for this PR? What is the status of this PR? Completely PR description after checking all your comments was updated https://github.com/pgspider/sqlite_fdw/pull/91#issue-1994632771
@mkgrgis , Thank you for your contribution.
@nxhai98 , Thank you for your confirmation.
I will merge the PR.
In this PR:
integer
-family out of range checks. SQLiteint
affinity is 1↔1 with PostgreSQLbigint
and also have equal ranges. If we haveint
orsmallint
in PostgreSQL some input values which is out of range for this data types are possible.sqlite3_column_@(stmt, colid)
functions inside ofsqlite_convert_to_pg
replaced tosqlite3_value_@(val)
functions for less parameters and fastest calculations, seesqlite3_value *sqlite3_column_value(sqlite3_stmt *pStmt, int i
) andstatic Mem *columnMem(sqlite3_stmt *pStmt, int i)
which will calculated once instead of manysqlite3_column_@(stmt, colid)
calls.out_of_range
test fromint4
, addint2
TCs https://github.com/pgspider/sqlite_fdw/pull/91/commits/641c539615b36ff203199b0c908524cf069ba358.bigint
PostgreSQL column can come a value withreal
affinity which is out of range. Add PostgreSQL input core function and TCs for this case.ErrorContextCallback
function with universal messages about any data conversion problems between PostgreSQL data column and SQLite data value.bitstring
test fromtype
test https://github.com/pgspider/sqlite_fdw/pull/91/commits/9bc53a470d0a51d40e34e4dfe6d25ad3e45fd3d3.dtof
tofloat4
PostgreSQL data column branch https://github.com/pgspider/sqlite_fdw/pull/91/commits/f0593dead92aad86ff27e7bea307984a4f3eeb97 (without testing, will tested in other PR about fullreal
affinity support)./tmp/sqlite_fdw_test
directory for less chaos in/tmp
https://github.com/pgspider/sqlite_fdw/pull/91/commits/cbba0432a2824c21912dc45f7b760ab4e350d54e . This allow reduce testing time.ForeignTable
andForeignServer
into...State
structures, because this variables are often calculated near this structures in functions like constructor. https://github.com/pgspider/sqlite_fdw/pull/91/commits/f1a1f89f733dc9f256c1c482018538c9964abdbe