pgsql-io / benchmarksql

A TPC-C like test tool
29 stars 11 forks source link

It seems to dont support MySQL,but doc files has MySQL #17

Open codeex opened 3 years ago

codeex commented 3 years ago

Do I miss something?

luss commented 3 years ago

BenchmarkSQL is designed and developed as a heterogeneous java application that should run against PostgreSQL, MySQL, and Oracle at the minimum (probably SQLSvr & DB2 also). Recent releases have been pretty rigorously tested and developed for PostgreSQL & Oracle so that it runs smoothly in both environments (without favoring either one). There may be some work to do to get it to run on MySQL. Contributions welcome.

PS. to Jan, please correct me if I'm wrong.

On Thu, Sep 23, 2021 at 9:42 AM CodeEx.CN @.***> wrote:

Do I miss something?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pgsql-io/benchmarksql/issues/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWOHW7CKMC65FUOWDD2PTUDMVE7ANCNFSM5ETXCDMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

wieck commented 3 years ago

On 9/23/21 11:14 AM, Denis Lussier wrote:

BenchmarkSQL is designed and developed as a heterogeneous java application that should run against PostgreSQL, MySQL, and Oracle at the minimum (probably SQLSvr & DB2 also). Recent releases have been pretty rigorously tested and developed for PostgreSQL & Oracle so that it runs smoothly in both environments (without favoring either one). There may be some work to do to get it to run on MySQL. Contributions welcome.

PS. to Jan, please correct me if I'm wrong.

The example .properties file is named sample.mariadb.properties and should work with MySQL just as well.

Best Regards

-- Jan Wieck

wieck commented 3 years ago

On 9/24/21 10:11 AM, Jan Wieck wrote:

On 9/23/21 11:14 AM, Denis Lussier wrote:

BenchmarkSQL is designed and developed as a heterogeneous java application that should run against PostgreSQL, MySQL, and Oracle at the minimum (probably SQLSvr & DB2 also). Recent releases have been pretty rigorously tested and developed for PostgreSQL & Oracle so that it runs smoothly in both environments (without favoring either one). There may be some work to do to get it to run on MySQL. Contributions welcome.

PS. to Jan, please correct me if I'm wrong.

The example .properties file is named sample.mariadb.properties and should work with MySQL just as well.

On second thought, where does the documentation mention MySQL? I thought I changed all that to MariaDB, which is binary compatible on the wire protocol level. The only references to MySQL that I can find in HEAD are in the pom.xml file where it downloads the mysql-connector-java artifact during the build process.

We might want to add some paragraph to the documentation that points MySQL users to using the MariaDB configuration as template. And maybe add a sample.mysql.properties file.

Regards, Jan

-- Jan Wieck

luss commented 3 years ago

I think leaving a single properties file named Mariab is fine. We can tweak to doc to mention MariaDB/MySQL

On Fri, Sep 24, 2021 at 11:34 AM Jan Wieck @.***> wrote:

On 9/24/21 10:11 AM, Jan Wieck wrote:

On 9/23/21 11:14 AM, Denis Lussier wrote:

BenchmarkSQL is designed and developed as a heterogeneous java application that should run against PostgreSQL, MySQL, and Oracle at the minimum (probably SQLSvr & DB2 also). Recent releases have been pretty rigorously tested and developed for PostgreSQL & Oracle so that it runs smoothly in both environments (without favoring either one). There may be some work to do to get it to run on MySQL. Contributions welcome.

PS. to Jan, please correct me if I'm wrong.

The example .properties file is named sample.mariadb.properties and should work with MySQL just as well.

On second thought, where does the documentation mention MySQL? I thought I changed all that to MariaDB, which is binary compatible on the wire protocol level. The only references to MySQL that I can find in HEAD are in the pom.xml file where it downloads the mysql-connector-java artifact during the build process.

We might want to add some paragraph to the documentation that points MySQL users to using the MariaDB configuration as template. And maybe add a sample.mysql.properties file.

Regards, Jan

-- Jan Wieck

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pgsql-io/benchmarksql/issues/17#issuecomment-926722076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWOHTCUC3X7WMNOLDIWMDUDSK65ANCNFSM5ETXCDMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

codeex commented 3 years ago

It' OK, Thank you for your work.