search

pgsql-io / multicorn2

http://multicorn2.org
Other
73 stars 16 forks source link

Is PG15 Supported #18

Closed luss closed 9 months ago

luss commented 1 year ago

PG 15 is presently at Beta4 and is expected to be RC & then GA in the next month or two. Does Multicorn2 support it?

luss commented 1 year ago

Yes, it's a work in process. Affan Salman is a new committer for this project and he has checked in a fix that allows us to build cleanly for PG15. I have tagged v2.4 that includes Affan's commit plus the work that Shaheed has been doing. Let the testing begin!!

devrimgunduz commented 1 year ago

Any updates?

wieck commented 1 year ago

I can test this once I am back home next week.

On Fri, Oct 28, 2022, 12:27 Devrim Gündüz @.***> wrote:

Any updates?

— Reply to this email directly, view it on GitHub https://github.com/pgsql-io/multicorn2/issues/18#issuecomment-1294825895, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYRMXZKSAA44WZJHYS6QTWFOTAFANCNFSM6AAAAAAQIO7U2Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

luss commented 1 year ago

YES. It is supported. And... I'd love to see Jan do some more testing. :-)

On Fri, Oct 28, 2022 at 6:32 AM Jan Wieck @.***> wrote:

I can test this once I am back home next week.

On Fri, Oct 28, 2022, 12:27 Devrim Gündüz @.***> wrote:

Any updates?

— Reply to this email directly, view it on GitHub < https://github.com/pgsql-io/multicorn2/issues/18#issuecomment-1294825895>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AACYRMXZKSAA44WZJHYS6QTWFOTAFANCNFSM6AAAAAAQIO7U2Q

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/pgsql-io/multicorn2/issues/18#issuecomment-1294830755, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWOHXRG5SKJE7U5BPM3L3WFOTSRANCNFSM6AAAAAAQIO7U2Q . You are receiving this because you authored the thread.Message ID: @.***>

luss commented 1 year ago

For this multicorn2 project, pg15 works as good as pg14 does. They both have a performance regression that hasn't been found yet. Pieces of the WHERE clause are not being pushed down in some cases they were in pg12 & pg13 in the original multicorn project.

ShaheedHaque commented 1 year ago

For this multicorn2 project, pg15 works as good as pg14 does.

Given that, can a release be cut please?

AnkilMPatel commented 1 year ago

Still While installing on PG15 Multicorn2, We got ERROR: Error in python: ModuleNotFoundError DETAIL: No module named 'multicorn' please help me

AnkilMPatel commented 1 year ago

@luss Not the above error is resolved but a new error is coming: ERROR: Error in python: AttributeError DETAIL: module 'multicorn' has no attribute 'get_class' SQL state: XX000

ShaheedHaque commented 1 year ago

Try looking in your PG server log. It may contain a stack trace that will be helpful

ShaheedHaque commented 9 months ago

@luss Not the above error is resolved but a new error is coming: ERROR: Error in python: AttributeError DETAIL: module 'multicorn' has no attribute 'get_class' SQL state: XX000

I've just hit this error too...it appears to be related to some other/bogus package called "multicorn":

$ pip3 show multicorn
Name: multicorn
Version: 0.1.0
Summary: 
Home-page: 
Author: An Long
Author-email: aisk1988@gmail.com
License: MIT
Location: /usr/lib/python3/dist-packages
...

This appears to be some kind of Web server/service, and is obviously clashing with the multicorn we expect.

The proximate cause seems to be that pip ends up using the wrong version of setuptools, and ends up NOT installing "our" multicorn but a package called UNKNOWN:

$ make
$ sudo make install
...
pip3.10 install  .
Processing /home/ubuntu/multicorn2-main
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: UNKNOWN
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-2.4-py3-none-any.whl size=1717 sha256=18dbaf25261e1ec673f579e1a0f239ee2581b7edef17c022cb14c4cdb182e66e
  Stored in directory: /root/.cache/pip/wheels/6d/cc/9b/8258a774060bcaa44b3e00e5b4af15b4946801ab9c7ec58c47
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
  Attempting uninstall: UNKNOWN
    Found existing installation: UNKNOWN 2.4
    Uninstalling UNKNOWN-2.4:
      Successfully uninstalled UNKNOWN-2.4
Successfully installed UNKNOWN-2.4

Then, in my case, another part of the installation containing the actual FDW - which depends on multicorn - ends up installing the other/"bogus" multicorn via pip.

The root cause appears to be https://github.com/pypa/setuptools/issues/3291 and https://github.com/pypa/pip/issues/6264. The real solution is not especially clear, but specifying "--no-build-isolation" during our install seems to sidestep the problem. I will do a bit more testing before proposing that as a fix.

luss commented 9 months ago

Pg15 is supported so I am closing this issue. A specific installation problem in one environment should be opened as a specific siiue.