Only detect a single pip executable when multiple candidate exist.

deathwish commented 1 year ago

Previously, due to incorrect use of Bash operator precedence, both (E.G.) pip3.9 and pip3 would be detected. This resulted in executing pip3.9 pip3 as the pip command, which is incorrect.

deathwish commented 1 year ago

This addresses #23, tested with pip3.9 and pip3 on $PATH.

ImreSamu commented 1 year ago

Thank you! my test is OK. :heavy_check_mark:

tested with:

FROM postgres:15-bullseye
RUN    apt-get update \
    && apt-get upgrade -y \
    && apt-get install -y --no-install-recommends \
       build-essential libreadline-dev zlib1g-dev flex bison libxml2-dev libxslt-dev libssl-dev libxml2-utils xsltproc \
       python3 python3-dev python3-setuptools python3-pip \
       git postgresql-server-dev-$PG_MAJOR python-is-python3 \
    && rm -rf /var/lib/apt/lists/*

RUN python3 -m pip install --no-cache-dir --upgrade pip
WORKDIR /multicorn2
RUN git clone --branch main https://github.com/deathwish/multicorn2.git  .
RUN git checkout e48c9eb5a0bad854fc4c0a43d5be833a3dc43183
RUN cat /etc/debian_version \
    && pip3 --version \
    && which pip3 \
    && make \
    && make install

deathwish commented 1 year ago

Great! Glad I could get it sorted.

pgsql-io / multicorn2

Only detect a single pip executable when multiple candidate exist. #24