search

pgsql-io / multicorn2

http://multicorn2.org
Other
73 stars 16 forks source link

PG14 and ldapfdw issue and latest Multicorn2 (v2.2.4) #32

Open mareban opened 9 months ago

mareban commented 9 months ago

hello,

We still have issue with ldapfdw on PG14 using a where clause :-( !

Is it a bug, is ldapfdw still supported on an Active Directory ?

We are getting this error message from python : KeyError: 'attributes'

Thanks for your help.

PS : With PG10 and ldapfdw from Secfault it was working like a charm.

luss commented 1 month ago

I'm hoping that Mathieu (highly skilled new commiter on this project) will fix this.

mfenniak commented 1 month ago

Hm... I don't have an LDAP system to test this against. @mareban is there an easy way to set one up and reproduce this issue? Can't guarantee I'd fix it, but I wouldn't know where to start in reproducing it right now. 🙂

If I had an LDAP system running to test this against (or if you do), what I would do is insert a line right before this... https://github.com/pgsql-io/multicorn2/blob/04c1667f65027ae85401e48725cfc34e6c6d6b72/python/multicorn/ldapfdw.py#L159 And drop in:

log_to_postgres("entry = %r" % (entry,))

Considering the error KeyError: 'attributes', it seems likely that the attribute on line 159 is missing, so you'd have to peek at what it is returning instead and adapt -- either the search query is wrong or the API has changed, or, maybe the FDW needs to be resilient to attributes missing and skip entries?