search

pgsql-io / multicorn2

http://multicorn2.org
Other
83 stars 17 forks source link

pg17 not compiling yet #55

Open luss opened 4 months ago

luss commented 4 months ago

I tagged 3.0beta1 and noticed and it looks like we need some #ifdef's to compile against pg17.

125:21: note: 'create_foreignscan_path' declared here 125 | extern ForeignPath create_foreignscan_path(PlannerInfo root, RelOptInfo rel, | ^ ~~~~~~~ 126 | PathTarget target, | ~~~~~~~ 127 | double rows, Cost startup_cost, Cost total_cost, | ~~~~~~~~~~~~ 128 | List pathkeys, | ~~~ 129 | Relids required_outer, | ~~~~~~ 130 | Path fdw_outerpath, | ~~~~ 131 | List fdw_restrictinfo, | ~~~~~~~ 132 | List fdw_private); | ~~~~~ 2 errors generated. make: *** [/opt/pgbin-build/pgbin/comp20240523_0820/build/multicorn-pg17-3.0beta1-1-arm9/lib/postgresql/pgxs/src/makefiles/../../src/Makefile.global:1090: src/multicorn.bc] Error 1 [build@eqn-arm9 bld]$

devrimgunduz commented 1 week ago

Hi @luss ,

This fixes the builds:

https://github.com/pgsql-io/multicorn2/commit/d57b9989862329bfc4ff0c70ea52c7b1200ff90d

Any chance you can release a new tarball so that I can build the RPMs?

Thanks!

Regards, Devrim

mfenniak commented 1 week ago

Note that multicorn2 isn't currently running any tests against PG17. The test suite can be updated in flake.nix but (lightly) requires the release to be packaged in nixpkgs first.