search

pgstath / Sharp.Xmpp

Sharp.Xmpp is looking for a maintainer! Unfortunatelly I do not have currently the time needed to maintain the library. Luckily a small but vibrant community has evolved around Sharp.Xmpp. If you would like to be the project's maintainer please sent an email to pgstath@gmail.com. This should include issues, tickets and commits that you have done for Sharp.Xmpp or other similar project. Sharp.Xmpp is a multiplatform, Windows and Android, .NET XMPP client assembly.Sharp.Xmpp supports IM functionality & a variety of XMPP extensions, is simple and is extensively tested against Android Xamarin. It is a fork of the currently frozen excellent S22.Xmpp project. Sharp.Xmpp will be at the FOSSDEM 2016 Real time DevRoom!
Other
84 stars 51 forks source link

Allow XMPP Server to be different from JID domain #41

Open stevenlivz opened 7 years ago

stevenlivz commented 7 years ago

Added support for specifying the XMPP server to connect to when it s different from the XMPP hostname in the JID.

marchanddesable commented 7 years ago

Hi,

You have updated the nuget package too? Because I don't think this update is in the current version of Sharp.Xmpp hosted in the nuget server.

Thanks.

ddrinka commented 5 years ago

@stevenlivz This is a really useful core PR, but it looks like your entire development process get pulled into it.

Usually the best approach to Git Flow is to create a branch in your repo for a PR, do the changes, and then create the PR from that branch. It looks like you created a PR from your master branch, so as you made additional changes, the PR grew out of control.

Would you mind cherry picking the first commit (9d5477a) off into a new branch and creating a new PR? Hopefully that could resolve folks problems (#65, #58, #34), and mine as well.