pgstath / Sharp.Xmpp

Sharp.Xmpp is looking for a maintainer! Unfortunatelly I do not have currently the time needed to maintain the library. Luckily a small but vibrant community has evolved around Sharp.Xmpp. If you would like to be the project's maintainer please sent an email to pgstath@gmail.com. This should include issues, tickets and commits that you have done for Sharp.Xmpp or other similar project. Sharp.Xmpp is a multiplatform, Windows and Android, .NET XMPP client assembly.Sharp.Xmpp supports IM functionality & a variety of XMPP extensions, is simple and is extensively tested against Android Xamarin. It is a fork of the currently frozen excellent S22.Xmpp project. Sharp.Xmpp will be at the FOSSDEM 2016 Real time DevRoom!
Other
84 stars 51 forks source link

XmppCore.IqRequest bug #54

Open cimframe opened 7 years ago

cimframe commented 7 years ago

In testing vCard avatar updates, a bug was detected in the request response parsing.

The old code:

if (request.To.Domain == Jid.Domain && (request.To.Node == null || request.To.Node == "") && (ping != null && ping.NamespaceURI == "urn:xmpp:ping"))

was replaced with:

if (request.To != null && request.To.Domain == Jid.Domain && string.IsNullOrEmpty (request.To.Node) && (ping != null && ping.NamespaceURI == "urn:xmpp:ping"))

The fact that avatars are sent out to a PEP subscription, there is no TO! That fixes that!