search

pgstef / check_pgbackrest

pgBackRest backup check plugin for Nagios
PostgreSQL License
35 stars 14 forks source link

add weak dependencies for rhel8 #11

Closed rippiedoos closed 4 years ago

rippiedoos commented 4 years ago

Allow for weak dependency in RHEL8 for the following packages:

The dependencies for Amazon S3 aren't included at all but the package perl-Net-SFTP-Foreign is hard forced. In a stock install of RHEL/OracleLinux 8 this package (from EPEL) has a dependency perl(IO::Pty), which is in the CodeReady Builder Channel. In RHEL8 not all systems have this channel enabled, which is full of dev-tools, and the package fails to install on regular systems.

This allows for installation on 'normal' systems but if you need this functionality, you should get those packages another way.

pgstef commented 4 years ago

Hi,

Thanks for your interest.

First of all, this spec file is only used to generate rhel7 rpm. Not 8. Then, it's not the spec file used in the PGDG yum repo. So it won't affect there unless I ask it to be replicated.

However, I do get your point of suggesting perl-Net-SFTP-Foreign rather than requesting it and apply the same strategy for S3 packages.

On CentOS7, the install.md file explains that an extra repo needs to be installed for S3 packages. That's why they are not part of the spec file.

I'll check how it could be implemented for rhel8 and if I could simply only suggest the SFTP dependency. It would definitively have more impacts on the tests also. I will also check what's the PGDG strategy and act accordingly.

Kind regards,

pgstef commented 4 years ago

At this point, I'm not in favor to accept that change. No test has been done on rhel 8 yet and I don't want to see S3 packages in the spec file. perl-Net-SFTP-Foreign could use "Recommends" rather than "Required" but that will have side effects and I have to find time to investigate that part.

rippiedoos commented 4 years ago

Thanks for the response. I've updated the issue with PGDG.