search

pgstef / check_pgbackrest

pgBackRest backup check plugin for Nagios
PostgreSQL License
35 stars 14 forks source link

add retention-incr option #27

Closed devopstales closed 2 years ago

devopstales commented 2 years ago

Add --retention-incr option

pgstef commented 2 years ago

Hi,

What's your use case for this ?

pgBackRest doesn't allow to expire incr backups given its design. You can't predict of much diff/incr you'll have in the repo given they will be expired with the backups they're referring to. So you can't really have a reliable minimum number.

Adding this option could lead to regular false alerts. I initially didn't added a retention-diff option because of that, and I'm currently not really willing to add this new option suggested for the same reason.

I'm open to the discussion though if you have a reliable use case for this.

Kind Regards

pgstef commented 2 years ago

Hi,

I took the time to think about your suggestion. Even if I don't see the interest of those 2 options (given it will be hard to set), the code to support it is pretty small and if it could be useful to someone, it worth adding it.

I then added the retention-diff option and some regression tests to support both options. It has then been merged.

I added you as devopstales in the release notes. Let me know if you wish to change that.

Have a good day, Kind Regards

devopstales commented 2 years ago

THX @pgstef