search

pgutkowski / KGraphQL

Pure Kotlin GraphQL implementation
MIT License
286 stars 82 forks source link

Support object literal arguments #13

Open malteseduck opened 6 years ago

malteseduck commented 6 years ago

Are there plans to support these? Your library is my favorite GraphQL library for Java/Kotlin, but not being able to send objects to my mutations makes it a deal-breaker for many of my projects.

prestongarno commented 6 years ago

I was curious as well, and it might be because of the rules for input objects listed in the spec?

http://facebook.github.io/graphql/October2016/#sec-Input-Objects

Moshi Json custom type adapters do this pretty cleanly and something similar might work here, though. Explicitly declaring schema types is already required in kgraphql, why not add a input object declaration DSL in the same place? @pgutkowski thoughts?

pgutkowski commented 6 years ago

Hi @malteseduck, thank you for your report.

I'd love to introduce support for object literals, but unfortunately lately I don't have much time due to my career and personal responsibilities. Additionally, responding to @prestongarno question, this feature is not there mainly because request parsing module is not designed well and it should be refactored before adding features.

I hope you know that you still can pass objects as arguments in variables, like in this test case

Anyway, with subscriptions and pagination it will be my main concern for future development.

jeggy commented 5 years ago

What's needed to implement this?