Expose fromSql method in node-pg

pgvector / pgvector-node

pgvector support for Node.js, Deno, and Bun (and TypeScript)

MIT License

303 stars 9 forks source link

Expose fromSql method in node-pg #8

Closed ghost closed 1 year ago

ghost commented 1 year ago

Changes

Exposed the fromSql method in the node-pg module for manual use cases where setting type doesn't work (like when using with Kysely where the DB schema doesn't have knowledge of the vector type)
Updated the toSql type signature to specify return type in node-pg module
Updated the README to:
- Show how to fetch vector from DB using fromSQL
- Show how to setup pgvector-node with node-pg pool in typescript

ankane commented 1 year ago

Hi @ronny-fraim, thanks for the PR! Added a pool example and test for node-postgres in 009773442e9a797b13ea58a336dfd54237cb264e. I haven't tried Kysely, but it may make sense to use pgvector/utils instead of pgvector/pg, which already has fromSql.

ghost commented 1 year ago

Hi @ronny-fraim, thanks for the PR! Added a pool example and test for node-postgres in 0097734. I haven't tried Kysely, but it may make sense to use pgvector/utils instead of pgvector/pg, which already has fromSql.

Oh cool, didn't realise that pgvector/utils was exposed, maybe worth adding that to the README too