search

pgvector / pgvector-python

pgvector support for Python
MIT License
951 stars 63 forks source link

Adding type annotations? #82

Closed pamelafox closed 3 months ago

pamelafox commented 3 months ago

I ran mypy on a codebase that uses pgvector, and saw that pgvector doesn't seem to have type annotations currently. Have you considered adding those, to allow for better type checking?

ankane commented 3 months ago

Hi @pamelafox, I still have similar thoughts as https://github.com/pgvector/pgvector-python/issues/57#issuecomment-1968064333 (not something I'd like to commit to supporting right now). However, someone could create a separate stubs package (similar to this one for Django).

pamelafox commented 3 months ago

Ah, I forgot about that discussion. We'll add pgvector to the ignore list for mypy for now, thanks for the reply!