search

ph-rast / bmgarch

Bayesian Multivariate GARCH
16 stars 10 forks source link

Compiler flags for next RStan Version #14

Closed andrjohns closed 3 years ago

andrjohns commented 3 years ago

Hi All,

This PR adds the changes to compiler flags needed for the next version of RStan.

Thanks! Andrew

ph-rast commented 3 years ago

Thanks for adding @andrjohns ; also, I noted today that rstantools wants me to place stanmodel definitions in 'inst/stan'. Currently they are in 'src/stan_files'. Do I need to change this in order to comply with rstan 2.27.0?

andrjohns commented 3 years ago

As far as I'm aware it's not a requirement, and all seems to build fine as-is. Having said that, it might be a good idea to move the models if it doesn't cause any issues, since it's where rstantools assumes they'll be. But it's not a necessary change at this point

codecov-commenter commented 3 years ago

Codecov Report

Merging #14 (6310d25) into master (497e265) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   42.12%   42.12%           
=======================================
  Files          16       16           
  Lines       13598    13598           
=======================================
  Hits         5728     5728           
  Misses       7870     7870

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36bdea3...6310d25. Read the comment docs.