ph-rast / bmgarch

Bayesian Multivariate GARCH
16 stars 10 forks source link

Use updated rstantools build process #17

Closed andrjohns closed 2 years ago

andrjohns commented 2 years ago

This PR allows your package to delegate the entirety of the build/install process to rstantools, which should simplify (if not remove) the rstan-related maintenance moving forward and also remove the NOTE mentioned in #16

andrjohns commented 2 years ago

Hm, the macOS failure to build only under the R CMD CHECK is unexpected. I'll close for now while I debug

andrjohns commented 2 years ago

Ah got it, missed updating the .gitignore

codecov-commenter commented 2 years ago

Codecov Report

Merging #17 (e0527d2) into master (23dc0e7) will increase coverage by 0.50%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   48.23%   48.74%   +0.50%     
==========================================
  Files          16       22       +6     
  Lines       13678    13808     +130     
==========================================
+ Hits         6598     6731     +133     
+ Misses       7080     7077       -3     
Impacted Files Coverage Δ
src/stan_files/forecastCCC.hpp
src/stan_files/CCCMGARCH.hpp
src/stan_files/pdBEKKMGARCH.hpp
src/stan_files/BEKKMGARCH.hpp
src/stan_files/DCCMGARCH.hpp
src/stan_files/forecastBEKK.hpp
src/stan_files/forecastDCC.hpp
src/stanExports_forecastBEKK.cc 100.00% <0.00%> (ø)
src/stanExports_pdBEKKMGARCH.cc 100.00% <0.00%> (ø)
src/stanExports_CCCMGARCH.cc 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23dc0e7...e0527d2. Read the comment docs.