ph4r05 / javacard-gradle-template

JavaCard project template for building CAP and running JCardSim with gradle + coverage
MIT License
50 stars 23 forks source link

Wrong RSA buffer size in encrypt mode #10

Closed lzaoral closed 4 years ago

lzaoral commented 5 years ago

The enclosed emulator fork creates a one-byte-shorter array when the RSA engine is used in encryption mode. The corresponding original issue in the upstream version of jCardSim: https://github.com/licel/jcardsim/issues/106.

It's quite interesting, that even though the issue was never fixed in the upstream GitHub repository, the 'com.licel:jcardsim:3.0.5' maven package creates buffer arrays of a correct length.

Corresponding pull request: https://github.com/ph4r05/jcardsim/pull/1

lzaoral commented 4 years ago

I have tested the latest master as ph4r05/jcardsim#1 is already merged for some time and the issue is indeed fixed. Thanks!