My group and I have been reviewing the Proposed Standards for Public Health Bioinformatics Software document from the perspective of a team dedicated to the development of analysis pipelines, and we have some observations, from our humble opinion and experience, about the document, that we hope could help in its development.
We believe it needs to be clearly defined whether these are minimum requirements, best practices, or guidelines, something we think its already under discussion in the meetings. We also think it should be clarified whether these are standards for pipelines or software, as some points may not apply to pipelines, and reversal.
We also believe that, in addition to indicating how this is going to be evaluated as Frank is working in his PR (https://github.com/pha4ge/pipeline-resources/pull/32), it could be useful to provide another section per point with resources, such as links or documents, that can assist developers with each of the standards.
Next, I will describe our observations on some of the points:
Commitment to Maintain: Perhaps it could be replaced with a section like "Maintenance Capability," as even if the commitment to maintain exists, it may not be fulfilled due to external factors or bad faith. Perhaps it is sufficient with the description/demonstration of how it will be maintained, having it considered in the README and contemplated in the pipeline's background (research project, master project, community...).
Documentation for Local Installation and/or Remote Access (e.g. Web Server or Galaxy/Terra Workflow): Some recommendations like pip, conda, etc., could be included for installation.
Software Performance: We do not believe that documenting this should be a minimum for a pipeline. Besides, it is relatively difficult for a small group of developers working alone, and it seems more like obtaining feedback from other groups or users.
Common File Formats: Is this going to be reviewed with a list of formats? A list would need to be provided in the standard's definition but alse kept up to date over time, which seems complicated but also relevant.
Software Security and Vulnerabilities: We do not see this as necessary for a pipeline. Perhaps for a website or database, but even then, in many cases, it is carried out by the security department of the institution externally to the code itself.
Here is a just proposal of reorganization to reduce the list to 10, which I believe was one of the next objectives:
Publicly-Accessible Repository
Version Control
Pipeline Documentation
Open-Source License
Contribution, Authorship, and Verified Point of Contact
Maintenance Capability
Conflict of Interest Statement
Pipeline Guidelines
Documentation for Local Installation and/or Remote Access
Software Functionality
Statement of Need with Respect to Public Health Pathogen Genomics
My group and I have been reviewing the Proposed Standards for Public Health Bioinformatics Software document from the perspective of a team dedicated to the development of analysis pipelines, and we have some observations, from our humble opinion and experience, about the document, that we hope could help in its development.
We believe it needs to be clearly defined whether these are minimum requirements, best practices, or guidelines, something we think its already under discussion in the meetings. We also think it should be clarified whether these are standards for pipelines or software, as some points may not apply to pipelines, and reversal.
We also believe that, in addition to indicating how this is going to be evaluated as Frank is working in his PR (https://github.com/pha4ge/pipeline-resources/pull/32), it could be useful to provide another section per point with resources, such as links or documents, that can assist developers with each of the standards.
Next, I will describe our observations on some of the points:
Here is a just proposal of reorganization to reduce the list to 10, which I believe was one of the next objectives: