phac-nml / biohansel

Rapidly subtype microbial genomes using single-nucleotide variant (SNV) subtyping schemes
Apache License 2.0
26 stars 7 forks source link

#13, #14: Quality Checking Module & Technician's Output #17

Closed mgopez closed 6 years ago

mgopez commented 6 years ago
mgopez commented 6 years ago

@peterk87, now Genevieve's QC module is implemented. Please let me know if you find anything I can refactor / change.

mgopez commented 6 years ago

@peterk87 I added in the new params for the QC module. They probably aren't the best names Words aren't coming to me right now, so if you have any suggestions let me know so I can change them.

mgopez commented 6 years ago

I added some tests to verify that the QC functions are working as expected. Please let me know if there's anything else you want me to change for this pr @peterk87.