To help make it more clear what's being changed or added for the scheme creation module, it would be a good idea to have a base branch to merge into so that's why scheme-creation/_base has been created.
Scheme creation relevant feature or change branches should be named scheme-creation/<name of feature> (e.g. scheme-creation/find-discriminatory-snvs) and a pull request should be opened to merge into scheme-creation/_base instead of development.
Subtyping specific and scheme creation specific code, tests and test data will be separate (biohansel/subtype vs biohansel/create, tests/subtype vs tests/create, tests/data/subtype vs tests/data/create) unless there is common function in some utility function.
To help make it more clear what's being changed or added for the scheme creation module, it would be a good idea to have a base branch to merge into so that's why
scheme-creation/_base
has been created.scheme-creation/<name of feature>
(e.g.scheme-creation/find-discriminatory-snvs
) and a pull request should be opened to merge intoscheme-creation/_base
instead ofdevelopment
.biohansel/subtype
vsbiohansel/create
,tests/subtype
vstests/create
,tests/data/subtype
vstests/data/create
) unless there is common function in some utility function.from biohansel.subtype.util import whatever
instead offrom util import whatever
; fully qualified path frombiohansel
)hansel
tobiohansel
to align with the name change frombio_hansel
tobiohansel
and to reduce confusion.