phac-nml / biohansel

Rapidly subtype microbial genomes using single-nucleotide variant (SNV) subtyping schemes
Apache License 2.0
25 stars 7 forks source link

Not failing QC with inconsistent results in first hierarchical level #88

Closed DarianHole closed 5 years ago

DarianHole commented 5 years ago

Samples are passing QC when they have inconsistent results. This is due to the QC module not checking against the first hierarchical level when determining if subtypes are consistent.

ex. A sample should fail QC if it is hitting subtype call 8.1 but missing subtype call 8

DarianHole commented 5 years ago

@glabbe Can you confirm that I have phrased this issue correctly?

glabbe commented 5 years ago

@DarianHole Yes that accurately describes the problem, thanks!

Takadonet commented 5 years ago

Resolved