phac-nml / irida-next

IRIDA Next
https://phac-nml.github.io/irida-next/
Apache License 2.0
8 stars 2 forks source link

Nextflow component fixes #537

Closed ericenns closed 3 months ago

ericenns commented 3 months ago

What does this PR do and why?

Describe in detail what your merge request does and why.

Fixes issue with section title and description not rendering due to workflow_params refactor. Fixes samplesheet file cell rendering when file inputs have meta tag (were incorrectly being parsed as metadata cells) Adds in autopopulating of fastq_1 file cell when it is not required and no other file cells are required.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Add mikrokondo to config/pipelines/pipelines.json

e.g.

{
  "url": "https://github.com/phac-nml/mikrokondo",
  "name": "phac-nml/mikrokondo",
  "description": "Mikrokondo beta",
  "versions": [
    {
      "name": "0.1.0"
    }
  ]
}

Launch server and select samples to run Mikrokondo, verify that file cells are rendered and that fastq_1 and fastq_2 (if pair present) are populated.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

github-actions[bot] commented 3 months ago

Simplecov Report

Covered Threshold
91.84% 90%